From 4888a14c12f5923f9974423370b24b1e392ff973 Mon Sep 17 00:00:00 2001
From: Vitor K <vitor-kiguchi@hotmail.com>
Date: Sun, 6 Dec 2020 19:36:04 -0300
Subject: [PATCH] Make UNIMPLEMENTED_MSG consistent with UNIMPLEMENTED (#5631)
The current inconsistency can result in a developer unintentionally
creating a crash when using UNIMPLEMENTED_MSG, if they're only
familiar with UNIMPLEMENTED. The two macros shouldn't have such
wildly different behaviors.
---
src/common/assert.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/common/assert.h b/src/common/assert.h
index c44fe8c36..2c7216464 100644
--- a/src/common/assert.h
+++ b/src/common/assert.h
@@ -55,4 +55,4 @@ assert_noinline_call(const Fn& fn) {
#endif
#define UNIMPLEMENTED() LOG_CRITICAL(Debug, "Unimplemented code!")
-#define UNIMPLEMENTED_MSG(_a_, ...) ASSERT_MSG(false, _a_, __VA_ARGS__)
+#define UNIMPLEMENTED_MSG(_a_, ...) LOG_CRITICAL(Debug, _a_, __VA_ARGS__)