mirror of
https://github.com/PabloMK7/citra.git
synced 2024-12-15 18:39:15 +00:00
dc39d06950
This commit fixes several kernel object leaks. The most severe of them was threads not being removed from the private handle table used for CoreTiming events. This resulted in Threads never being released, which in turn held references to Process, causing CodeSets to never be freed when loading other applications.
75 lines
2.4 KiB
C++
75 lines
2.4 KiB
C++
// Copyright 2014 Citra Emulator Project
|
|
// Licensed under GPLv2 or any later version
|
|
// Refer to the license.txt file included.
|
|
|
|
#include "common/logging/log.h"
|
|
|
|
#include "core/hle/hle.h"
|
|
#include "core/hle/service/srv.h"
|
|
#include "core/hle/kernel/event.h"
|
|
|
|
////////////////////////////////////////////////////////////////////////////////////////////////////
|
|
// Namespace SRV
|
|
|
|
namespace SRV {
|
|
|
|
static Kernel::SharedPtr<Kernel::Event> event_handle;
|
|
|
|
static void Initialize(Service::Interface* self) {
|
|
u32* cmd_buff = Kernel::GetCommandBuffer();
|
|
|
|
cmd_buff[1] = 0; // No error
|
|
}
|
|
|
|
static void GetProcSemaphore(Service::Interface* self) {
|
|
u32* cmd_buff = Kernel::GetCommandBuffer();
|
|
|
|
// TODO(bunnei): Change to a semaphore once these have been implemented
|
|
event_handle = Kernel::Event::Create(RESETTYPE_ONESHOT, "SRV:Event");
|
|
event_handle->Clear();
|
|
|
|
cmd_buff[1] = 0; // No error
|
|
cmd_buff[3] = Kernel::g_handle_table.Create(event_handle).MoveFrom();
|
|
}
|
|
|
|
static void GetServiceHandle(Service::Interface* self) {
|
|
ResultCode res = RESULT_SUCCESS;
|
|
u32* cmd_buff = Kernel::GetCommandBuffer();
|
|
|
|
std::string port_name = std::string((const char*)&cmd_buff[1], 0, Service::kMaxPortSize);
|
|
auto it = Service::g_srv_services.find(port_name);
|
|
|
|
if (it != Service::g_srv_services.end()) {
|
|
cmd_buff[3] = Kernel::g_handle_table.Create(it->second).MoveFrom();
|
|
LOG_TRACE(Service_SRV, "called port=%s, handle=0x%08X", port_name.c_str(), cmd_buff[3]);
|
|
} else {
|
|
LOG_ERROR(Service_SRV, "(UNIMPLEMENTED) called port=%s", port_name.c_str());
|
|
res = UnimplementedFunction(ErrorModule::SRV);
|
|
}
|
|
cmd_buff[1] = res.raw;
|
|
}
|
|
|
|
const Interface::FunctionInfo FunctionTable[] = {
|
|
{0x00010002, Initialize, "Initialize"},
|
|
{0x00020000, GetProcSemaphore, "GetProcSemaphore"},
|
|
{0x00030100, nullptr, "RegisterService"},
|
|
{0x000400C0, nullptr, "UnregisterService"},
|
|
{0x00050100, GetServiceHandle, "GetServiceHandle"},
|
|
{0x000600C2, nullptr, "RegisterHandle"},
|
|
{0x00090040, nullptr, "Subscribe"},
|
|
{0x000B0000, nullptr, "ReceiveNotification"},
|
|
{0x000C0080, nullptr, "PublishToSubscriber"},
|
|
};
|
|
|
|
////////////////////////////////////////////////////////////////////////////////////////////////////
|
|
// Interface class
|
|
|
|
Interface::Interface() {
|
|
Register(FunctionTable);
|
|
}
|
|
|
|
Interface::~Interface() {
|
|
event_handle = nullptr;
|
|
}
|
|
|
|
} // namespace
|