From b0d91e9f310f86b4eb9d75c92471831f1656ed1b Mon Sep 17 00:00:00 2001 From: Mathias Koch Date: Thu, 15 Sep 2022 05:38:55 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Jacob Gonzalez --- embassy-rp/src/i2c.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/embassy-rp/src/i2c.rs b/embassy-rp/src/i2c.rs index 19cdef133..12fae3b7b 100644 --- a/embassy-rp/src/i2c.rs +++ b/embassy-rp/src/i2c.rs @@ -144,7 +144,7 @@ impl<'d, T: Instance> I2c<'d, T, Async> { let len = buffer.len(); self.read_blocking_internal(&mut buffer[..1], true, len == 1)?; - if len > 2 { + if len >= 2 { // Note(safety): Unwrap should be safe, as this can only be called // when `Mode == Async`, where we have dma channels. let ch = self.rx_dma.as_mut().unwrap(); @@ -168,7 +168,7 @@ impl<'d, T: Instance> I2c<'d, T, Async> { transfer.await; } - if len > 2 { + if len >= 2 { self.read_blocking_internal(&mut buffer[len - 1..], false, true)?; } @@ -202,7 +202,7 @@ impl<'d, T: Instance> I2c<'d, T, Async> { if bytes.is_empty() { self.write_blocking_internal(bytes, false)?; } else { - self.write_internal(bytes, false).await?; + self.write_internal(bytes, true).await?; } if buffer.is_empty() {