gdbstub: Fix some bugs in IsMemoryBreak() and ServeBreak. Add workaround to let watchpoints break into GDB. (#4651)

* gdbstub: fix IsMemoryBreak() returning false while connected to client

As a result, the only existing codepath for a memory watchpoint hit to break into GDB (InterpeterMainLoop, GDB_BP_CHECK, ARMul_State::RecordBreak) is finally taken,
which exposes incorrect logic* in both RecordBreak and ServeBreak.

* a blank BreakpointAddress structure is passed, which sets r15 (PC) to NULL

* gdbstub: DynCom: default-initialize two members/vars used in conditionals

* gdbstub: DynCom: don't record memory watchpoint hits via RecordBreak()

For now, instead check for GDBStub::IsMemoryBreak() in InterpreterMainLoop and ServeBreak.

Fixes PC being set to a stale/unhit breakpoint address (often zero) when a memory watchpoint (rwatch, watch, awatch) is handled in ServeBreak() and generates a GDB trap.

Reasons for removing a call to RecordBreak() for memory watchpoints:
* The``breakpoint_data`` we pass is typed Execute or None. It describes the predicted next code breakpoint hit relative to PC;

* GDBStub::IsMemoryBreak() returns true if a recent Read/Write operation hit a watchpoint. It doesn't specify which in return, nor does it trace it anywhere. Thus, the only data we could give RecordBreak() is a placeholder BreakpointAddress at offset NULL and type Access. I found the idea silly, compared to simply relying on GDBStub::IsMemoryBreak().

There is currently no measure in the code that remembers the addresses (and types) of any watchpoints that were hit by an instruction, in order to send them to GDB as "extended stop information."
I'm considering an implementation for this.

* gdbstub: Change an ASSERT to DEBUG_ASSERT

I have never seen the (Reg[15] == last_bkpt.address) assert fail in practice, even after several weeks of (locally) developping various branches around GDB.  Only leave it inside Debug builds.

src/core/arm/dyncom/arm_dyncom_interpreter.cpp

@@ -923,7 +923,9 @@ MICROPROFILE_DEFINE(DynCom_Execute, "DynCom", "Execute", MP_RGB(255, 0, 0));
 unsigned InterpreterMainLoop(ARMul_State* cpu) {
     MICROPROFILE_SCOPE(DynCom_Execute);
 
+    /// Nearest upcoming GDB code execution breakpoint, relative to the last dispatch's address.
     GDBStub::BreakpointAddress breakpoint_data;
+    breakpoint_data.type = GDBStub::BreakpointType::None;
 
 #undef RM
 #undef RS
@@ -955,8 +957,10 @@ unsigned InterpreterMainLoop(ARMul_State* cpu) {
     cpu->Cpsr &= ~(1 << 5);                                                                        \
     cpu->Cpsr |= cpu->TFlag << 5;                                                                  \
     if (GDBStub::IsServerEnabled()) {                                                              \
-        if (GDBStub::IsMemoryBreak() || (breakpoint_data.type != GDBStub::BreakpointType::None &&  \
+        if (GDBStub::IsMemoryBreak()) {                                                            \
-                                         PC == breakpoint_data.address)) {                         \
+            goto END;                                                                              \
+        } else if (breakpoint_data.type != GDBStub::BreakpointType::None &&                        \
+                   PC == breakpoint_data.address) {                                                \
             cpu->RecordBreak(breakpoint_data);                                                     \
             goto END;                                                                              \
         }                                                                                          \

src/core/arm/skyeye_common/armstate.cpp

@@ -602,13 +602,15 @@ void ARMul_State::ServeBreak() {
         return;
     }
 
-    if (last_bkpt_hit) {
+    if (last_bkpt_hit && last_bkpt.type == GDBStub::BreakpointType::Execute) {
-        Reg[15] = last_bkpt.address;
+        DEBUG_ASSERT(Reg[15] == last_bkpt.address);
     }
+
     DEBUG_ASSERT(system != nullptr);
     Kernel::Thread* thread = system->Kernel().GetThreadManager().GetCurrentThread();
     system->CPU().SaveContext(thread->context);
-    if (last_bkpt_hit || GDBStub::GetCpuStepFlag()) {
+
+    if (last_bkpt_hit || GDBStub::IsMemoryBreak() || GDBStub::GetCpuStepFlag()) {
         last_bkpt_hit = false;
         GDBStub::Break();
         GDBStub::SendTrap(thread, 5);

src/core/arm/skyeye_common/armstate.h

@@ -268,5 +268,5 @@ private:
     bool exclusive_state;
 
     GDBStub::BreakpointAddress last_bkpt{};
-    bool last_bkpt_hit;
+    bool last_bkpt_hit = false;
 };

src/core/gdbstub/gdbstub.cpp

@@ -892,7 +892,7 @@ static void Step() {
 }
 
 bool IsMemoryBreak() {
-    if (IsConnected()) {
+    if (!IsConnected()) {
         return false;
     }