NaxdyOrg/embassy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Update stm32-metapac, includes chiptool changes to use real Rust enums now.

Browse source
This commit is contained in:
Dario Nieuwenhuis 2023-06-29 01:51:19 +02:00
parent 8cbe5b8e20
commit e892014b65
25 changed files with 121 additions and 125 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
embassy-stm32/Cargo.toml
View file

@ -57,7 +57,7 @@ sdio-host = "0.5.0"
embedded-sdmmc = { git = "https://github.com/embassy-rs/embedded-sdmmc-rs", rev = "a4f293d3a6f72158385f79c98634cb8a14d0d2fc", optional = true } embedded-sdmmc = { git = "https://github.com/embassy-rs/embedded-sdmmc-rs", rev = "a4f293d3a6f72158385f79c98634cb8a14d0d2fc", optional = true }
critical-section = "1.1" critical-section = "1.1"
atomic-polyfill = "1.0.1" atomic-polyfill = "1.0.1"
stm32-metapac = "11" stm32-metapac = "12"
vcell = "0.1.3" vcell = "0.1.3"
bxcan = "0.7.0" bxcan = "0.7.0"
nb = "1.0.0" nb = "1.0.0"
@ -74,7 +74,7 @@ critical-section = { version = "1.1", features = ["std"] }
[build-dependencies] [build-dependencies]
proc-macro2 = "1.0.36" proc-macro2 = "1.0.36"
quote = "1.0.15" quote = "1.0.15"
stm32-metapac = { version = "11", default-features = false, features = ["metadata"]} stm32-metapac = { version = "12", default-features = false, features = ["metadata"]}
[features] [features]
default = ["rt"] default = ["rt"]

8
embassy-stm32/src/adc/v3.rs
View file

@ -211,10 +211,8 @@ impl<'d, T: Instance> Adc<'d, T> {
#[cfg(not(stm32g0))] #[cfg(not(stm32g0))]
fn set_channel_sample_time(ch: u8, sample_time: SampleTime) { fn set_channel_sample_time(ch: u8, sample_time: SampleTime) {
let sample_time = sample_time.into(); let sample_time = sample_time.into();
if ch <= 9 { T::regs()
T::regs().smpr1().modify(|reg| reg.set_smp(ch as _, sample_time)); .smpr(ch as usize / 10)
} else { .modify(|reg| reg.set_smp(ch as usize % 10, sample_time));
T::regs().smpr2().modify(|reg| reg.set_smp((ch - 10) as _, sample_time));
}
} }
} }

8
embassy-stm32/src/can/bxcan.rs
View file

@ -116,10 +116,10 @@ impl<'d, T: Instance> Can<'d, T> {
T::regs().ier().write(|w| { T::regs().ier().write(|w| {
// TODO: fix metapac // TODO: fix metapac
w.set_errie(Errie(1)); w.set_errie(Errie::from_bits(1));
w.set_fmpie(0, Fmpie(1)); w.set_fmpie(0, Fmpie::from_bits(1));
w.set_fmpie(1, Fmpie(1)); w.set_fmpie(1, Fmpie::from_bits(1));
w.set_tmeie(Tmeie(1)); w.set_tmeie(Tmeie::from_bits(1));
}); });
T::regs().mcr().write(|w| { T::regs().mcr().write(|w| {

2
embassy-stm32/src/eth/v1/rx_desc.rs
View file

@ -174,7 +174,7 @@ impl<'a> RDesRing<'a> {
// Receive descriptor unavailable // Receive descriptor unavailable
Rps::SUSPENDED => RunningState::Stopped, Rps::SUSPENDED => RunningState::Stopped,
// Closing receive descriptor // Closing receive descriptor
Rps(0b101) => RunningState::Running, Rps::_RESERVED_5 => RunningState::Running,
// Transferring the receive packet data from receive buffer to host memory // Transferring the receive packet data from receive buffer to host memory
Rps::RUNNINGWRITING => RunningState::Running, Rps::RUNNINGWRITING => RunningState::Running,
_ => RunningState::Unknown, _ => RunningState::Unknown,

2
embassy-stm32/src/pwm/complementary_pwm.rs
View file

@ -243,7 +243,7 @@ mod tests {
for test_run in fn_results { for test_run in fn_results {
let (ckd, bits) = compute_dead_time_value(test_run.value); let (ckd, bits) = compute_dead_time_value(test_run.value);
assert_eq!(ckd.0, test_run.ckd.0); assert_eq!(ckd.to_bits(), test_run.ckd.to_bits());
assert_eq!(bits, test_run.bits); assert_eq!(bits, test_run.bits);
} }
} }

10
embassy-stm32/src/rcc/c0.rs
View file

@ -126,7 +126,7 @@ pub(crate) unsafe fn init(config: Config) {
}); });
while !RCC.cr().read().hsirdy() {} while !RCC.cr().read().hsirdy() {}
(HSI_FREQ.0 >> div.0, Sw::HSI) (HSI_FREQ.0 >> div.to_bits(), Sw::HSI)
} }
ClockSrc::HSE(freq) => { ClockSrc::HSE(freq) => {
// Enable HSE // Enable HSE
@ -157,7 +157,7 @@ pub(crate) unsafe fn init(config: Config) {
let mut set_flash_latency_after = false; let mut set_flash_latency_after = false;
FLASH.acr().modify(|w| { FLASH.acr().modify(|w| {
// Is the current flash latency less than what we need at the new SYSCLK? // Is the current flash latency less than what we need at the new SYSCLK?
if w.latency().0 <= target_flash_latency.0 { if w.latency().to_bits() <= target_flash_latency.to_bits() {
// We must increase the number of wait states now // We must increase the number of wait states now
w.set_latency(target_flash_latency) w.set_latency(target_flash_latency)
} else { } else {
@ -171,12 +171,12 @@ pub(crate) unsafe fn init(config: Config) {
// > Flash memory. // > Flash memory.
// //
// Enable flash prefetching if we have at least one wait state, and disable it otherwise. // Enable flash prefetching if we have at least one wait state, and disable it otherwise.
w.set_prften(target_flash_latency.0 > 0); w.set_prften(target_flash_latency.to_bits() > 0);
}); });
if !set_flash_latency_after { if !set_flash_latency_after {
// Spin until the effective flash latency is compatible with the clock change // Spin until the effective flash latency is compatible with the clock change
while FLASH.acr().read().latency().0 < target_flash_latency.0 {} while FLASH.acr().read().latency().to_bits() < target_flash_latency.to_bits() {}
} }
// Configure SYSCLK source, HCLK divisor, and PCLK divisor all at once // Configure SYSCLK source, HCLK divisor, and PCLK divisor all at once
@ -218,7 +218,7 @@ pub(crate) unsafe fn init(config: Config) {
APBPrescaler::NotDivided => (ahb_freq, ahb_freq), APBPrescaler::NotDivided => (ahb_freq, ahb_freq),
pre => { pre => {
let pre: Ppre = pre.into(); let pre: Ppre = pre.into();
let pre: u8 = 1 << (pre.0 - 3); let pre: u8 = 1 << (pre.to_bits() - 3);
let freq = ahb_freq / pre as u32; let freq = ahb_freq / pre as u32;
(freq, freq * 2) (freq, freq * 2)
} }

23
embassy-stm32/src/rcc/f0.rs
View file

@ -1,3 +1,5 @@
use stm32_metapac::flash::vals::Latency;
use super::{set_freqs, Clocks}; use super::{set_freqs, Clocks};
use crate::pac::rcc::vals::{Hpre, Pllmul, Pllsrc, Ppre, Sw, Usbsw}; use crate::pac::rcc::vals::{Hpre, Pllmul, Pllsrc, Ppre, Sw, Usbsw};
use crate::pac::{FLASH, RCC}; use crate::pac::{FLASH, RCC};
@ -85,14 +87,11 @@ pub(crate) unsafe fn init(config: Config) {
let timer_mul = if ppre == 1 { 1 } else { 2 }; let timer_mul = if ppre == 1 { 1 } else { 2 };
FLASH.acr().write(|w| { FLASH.acr().write(|w| {
let latency = if real_sysclk <= 24_000_000 { w.set_latency(if real_sysclk <= 24_000_000 {
0 Latency::WS0
} else if real_sysclk <= 48_000_000 {
1
} else { } else {
2 Latency::WS1
}; });
w.latency().0 = latency;
}); });
match (config.hse.is_some(), use_hsi48) { match (config.hse.is_some(), use_hsi48) {
@ -134,20 +133,20 @@ pub(crate) unsafe fn init(config: Config) {
// TODO: Option to use CRS (Clock Recovery) // TODO: Option to use CRS (Clock Recovery)
if let Some(pllmul_bits) = pllmul_bits { if let Some(pllmul_bits) = pllmul_bits {
RCC.cfgr().modify(|w| w.set_pllmul(Pllmul(pllmul_bits))); RCC.cfgr().modify(|w| w.set_pllmul(Pllmul::from_bits(pllmul_bits)));
RCC.cr().modify(|w| w.set_pllon(true)); RCC.cr().modify(|w| w.set_pllon(true));
while !RCC.cr().read().pllrdy() {} while !RCC.cr().read().pllrdy() {}
RCC.cfgr().modify(|w| { RCC.cfgr().modify(|w| {
w.set_ppre(Ppre(ppre_bits)); w.set_ppre(Ppre::from_bits(ppre_bits));
w.set_hpre(Hpre(hpre_bits)); w.set_hpre(Hpre::from_bits(hpre_bits));
w.set_sw(Sw::PLL) w.set_sw(Sw::PLL)
}); });
} else { } else {
RCC.cfgr().modify(|w| { RCC.cfgr().modify(|w| {
w.set_ppre(Ppre(ppre_bits)); w.set_ppre(Ppre::from_bits(ppre_bits));
w.set_hpre(Hpre(hpre_bits)); w.set_hpre(Hpre::from_bits(hpre_bits));
if config.hse.is_some() { if config.hse.is_some() {
w.set_sw(Sw::HSE); w.set_sw(Sw::HSE);

36
embassy-stm32/src/rcc/f1.rs
View file

@ -106,11 +106,11 @@ pub(crate) unsafe fn init(config: Config) {
// Only needed for stm32f103? // Only needed for stm32f103?
FLASH.acr().write(|w| { FLASH.acr().write(|w| {
w.set_latency(if real_sysclk <= 24_000_000 { w.set_latency(if real_sysclk <= 24_000_000 {
Latency(0b000) Latency::WS0
} else if real_sysclk <= 48_000_000 { } else if real_sysclk <= 48_000_000 {
Latency(0b001) Latency::WS1
} else { } else {
Latency(0b010) Latency::WS2
}); });
}); });
@ -147,12 +147,13 @@ pub(crate) unsafe fn init(config: Config) {
if let Some(pllmul_bits) = pllmul_bits { if let Some(pllmul_bits) = pllmul_bits {
let pllctpre_flag: u8 = if config.pllxtpre { 1 } else { 0 }; let pllctpre_flag: u8 = if config.pllxtpre { 1 } else { 0 };
RCC.cfgr().modify(|w| w.set_pllxtpre(Pllxtpre(pllctpre_flag))); RCC.cfgr()
.modify(|w| w.set_pllxtpre(Pllxtpre::from_bits(pllctpre_flag)));
// enable PLL and wait for it to be ready // enable PLL and wait for it to be ready
RCC.cfgr().modify(|w| { RCC.cfgr().modify(|w| {
w.set_pllmul(Pllmul(pllmul_bits)); w.set_pllmul(Pllmul::from_bits(pllmul_bits));
w.set_pllsrc(Pllsrc(config.hse.is_some() as u8)); w.set_pllsrc(Pllsrc::from_bits(config.hse.is_some() as u8));
}); });
RCC.cr().modify(|w| w.set_pllon(true)); RCC.cr().modify(|w| w.set_pllon(true));
@ -161,22 +162,19 @@ pub(crate) unsafe fn init(config: Config) {
// Only needed for stm32f103? // Only needed for stm32f103?
RCC.cfgr().modify(|w| { RCC.cfgr().modify(|w| {
w.set_adcpre(Adcpre(apre_bits)); w.set_adcpre(Adcpre::from_bits(apre_bits));
w.set_ppre2(Ppre1(ppre2_bits)); w.set_ppre2(Ppre1::from_bits(ppre2_bits));
w.set_ppre1(Ppre1(ppre1_bits)); w.set_ppre1(Ppre1::from_bits(ppre1_bits));
w.set_hpre(Hpre(hpre_bits)); w.set_hpre(Hpre::from_bits(hpre_bits));
#[cfg(not(rcc_f100))] #[cfg(not(rcc_f100))]
w.set_usbpre(Usbpre(usbpre as u8)); w.set_usbpre(Usbpre::from_bits(usbpre as u8));
w.set_sw(Sw(if pllmul_bits.is_some() { w.set_sw(if pllmul_bits.is_some() {
// PLL Sw::PLL
0b10
} else if config.hse.is_some() { } else if config.hse.is_some() {
// HSE Sw::HSE
0b1
} else { } else {
// HSI Sw::HSI
0b0 });
}));
}); });
set_freqs(Clocks { set_freqs(Clocks {

2
embassy-stm32/src/rcc/f2.rs
View file

@ -485,7 +485,7 @@ pub(crate) unsafe fn init(config: Config) {
w.set_ppre1(config.apb1_pre.into()); w.set_ppre1(config.apb1_pre.into());
w.set_ppre2(config.apb2_pre.into()); w.set_ppre2(config.apb2_pre.into());
}); });
while RCC.cfgr().read().sws() != sw.0 {} while RCC.cfgr().read().sws().to_bits() != sw.to_bits() {}
// Turn off HSI to save power if we don't need it // Turn off HSI to save power if we don't need it
if !config.hsi { if !config.hsi {

12
embassy-stm32/src/rcc/f4.rs
View file

@ -87,7 +87,7 @@ fn setup_pll(pllsrcclk: u32, use_hse: bool, pllsysclk: Option<u32>, plli2s: Opti
let sysclk = pllsysclk.unwrap_or(pllsrcclk); let sysclk = pllsysclk.unwrap_or(pllsrcclk);
if pllsysclk.is_none() && !pll48clk { if pllsysclk.is_none() && !pll48clk {
RCC.pllcfgr().modify(|w| w.set_pllsrc(Pllsrc(use_hse as u8))); RCC.pllcfgr().modify(|w| w.set_pllsrc(Pllsrc::from_bits(use_hse as u8)));
return PllResults { return PllResults {
use_pll: false, use_pll: false,
@ -141,9 +141,9 @@ fn setup_pll(pllsrcclk: u32, use_hse: bool, pllsysclk: Option<u32>, plli2s: Opti
RCC.pllcfgr().modify(|w| { RCC.pllcfgr().modify(|w| {
w.set_pllm(pllm as u8); w.set_pllm(pllm as u8);
w.set_plln(plln as u16); w.set_plln(plln as u16);
w.set_pllp(Pllp(pllp as u8)); w.set_pllp(Pllp::from_bits(pllp as u8));
w.set_pllq(pllq as u8); w.set_pllq(pllq as u8);
w.set_pllsrc(Pllsrc(use_hse as u8)); w.set_pllsrc(Pllsrc::from_bits(use_hse as u8));
}); });
let real_pllsysclk = vco_in * plln / sysclk_div; let real_pllsysclk = vco_in * plln / sysclk_div;
@ -323,7 +323,7 @@ fn flash_setup(sysclk: u32) {
critical_section::with(|_| { critical_section::with(|_| {
FLASH FLASH
.acr() .acr()
.modify(|w| w.set_latency(Latency(((sysclk - 1) / FLASH_LATENCY_STEP) as u8))); .modify(|w| w.set_latency(Latency::from_bits(((sysclk - 1) / FLASH_LATENCY_STEP) as u8)));
}); });
} }
@ -440,8 +440,8 @@ pub(crate) unsafe fn init(config: Config) {
} }
RCC.cfgr().modify(|w| { RCC.cfgr().modify(|w| {
w.set_ppre2(Ppre(ppre2_bits)); w.set_ppre2(Ppre::from_bits(ppre2_bits));
w.set_ppre1(Ppre(ppre1_bits)); w.set_ppre1(Ppre::from_bits(ppre1_bits));
w.set_hpre(hpre_bits); w.set_hpre(hpre_bits);
}); });

12
embassy-stm32/src/rcc/f7.rs
View file

@ -30,7 +30,7 @@ fn setup_pll(pllsrcclk: u32, use_hse: bool, pllsysclk: Option<u32>, pll48clk: bo
let sysclk = pllsysclk.unwrap_or(pllsrcclk); let sysclk = pllsysclk.unwrap_or(pllsrcclk);
if pllsysclk.is_none() && !pll48clk { if pllsysclk.is_none() && !pll48clk {
RCC.pllcfgr().modify(|w| w.set_pllsrc(Pllsrc(use_hse as u8))); RCC.pllcfgr().modify(|w| w.set_pllsrc(Pllsrc::from_bits(use_hse as u8)));
return PllResults { return PllResults {
use_pll: false, use_pll: false,
@ -83,9 +83,9 @@ fn setup_pll(pllsrcclk: u32, use_hse: bool, pllsysclk: Option<u32>, pll48clk: bo
RCC.pllcfgr().modify(|w| { RCC.pllcfgr().modify(|w| {
w.set_pllm(pllm as u8); w.set_pllm(pllm as u8);
w.set_plln(plln as u16); w.set_plln(plln as u16);
w.set_pllp(Pllp(pllp as u8)); w.set_pllp(Pllp::from_bits(pllp as u8));
w.set_pllq(pllq as u8); w.set_pllq(pllq as u8);
w.set_pllsrc(Pllsrc(use_hse as u8)); w.set_pllsrc(Pllsrc::from_bits(use_hse as u8));
}); });
let real_pllsysclk = vco_in * plln / sysclk_div; let real_pllsysclk = vco_in * plln / sysclk_div;
@ -106,7 +106,7 @@ fn flash_setup(sysclk: u32) {
critical_section::with(|_| { critical_section::with(|_| {
FLASH FLASH
.acr() .acr()
.modify(|w| w.set_latency(Latency(((sysclk - 1) / FLASH_LATENCY_STEP) as u8))); .modify(|w| w.set_latency(Latency::from_bits(((sysclk - 1) / FLASH_LATENCY_STEP) as u8)));
}); });
} }
@ -246,8 +246,8 @@ pub(crate) unsafe fn init(config: Config) {
} }
RCC.cfgr().modify(|w| { RCC.cfgr().modify(|w| {
w.set_ppre2(Ppre(ppre2_bits)); w.set_ppre2(Ppre::from_bits(ppre2_bits));
w.set_ppre1(Ppre(ppre1_bits)); w.set_ppre1(Ppre::from_bits(ppre1_bits));
w.set_hpre(hpre_bits); w.set_hpre(hpre_bits);
}); });

10
embassy-stm32/src/rcc/g0.rs
View file

@ -344,7 +344,7 @@ pub(crate) unsafe fn init(config: Config) {
}); });
while !RCC.cr().read().hsirdy() {} while !RCC.cr().read().hsirdy() {}
(HSI_FREQ.0 >> div.0, Sw::HSI) (HSI_FREQ.0 >> div.to_bits(), Sw::HSI)
} }
ClockSrc::HSE(freq) => { ClockSrc::HSE(freq) => {
// Enable HSE // Enable HSE
@ -381,7 +381,7 @@ pub(crate) unsafe fn init(config: Config) {
let mut set_flash_latency_after = false; let mut set_flash_latency_after = false;
FLASH.acr().modify(|w| { FLASH.acr().modify(|w| {
// Is the current flash latency less than what we need at the new SYSCLK? // Is the current flash latency less than what we need at the new SYSCLK?
if w.latency().0 <= target_flash_latency.0 { if w.latency().to_bits() <= target_flash_latency.to_bits() {
// We must increase the number of wait states now // We must increase the number of wait states now
w.set_latency(target_flash_latency) w.set_latency(target_flash_latency)
} else { } else {
@ -395,12 +395,12 @@ pub(crate) unsafe fn init(config: Config) {
// > Flash memory. // > Flash memory.
// //
// Enable flash prefetching if we have at least one wait state, and disable it otherwise. // Enable flash prefetching if we have at least one wait state, and disable it otherwise.
w.set_prften(target_flash_latency.0 > 0); w.set_prften(target_flash_latency.to_bits() > 0);
}); });
if !set_flash_latency_after { if !set_flash_latency_after {
// Spin until the effective flash latency is compatible with the clock change // Spin until the effective flash latency is compatible with the clock change
while FLASH.acr().read().latency().0 < target_flash_latency.0 {} while FLASH.acr().read().latency().to_bits() < target_flash_latency.to_bits() {}
} }
// Configure SYSCLK source, HCLK divisor, and PCLK divisor all at once // Configure SYSCLK source, HCLK divisor, and PCLK divisor all at once
@ -442,7 +442,7 @@ pub(crate) unsafe fn init(config: Config) {
APBPrescaler::NotDivided => (ahb_freq, ahb_freq), APBPrescaler::NotDivided => (ahb_freq, ahb_freq),
pre => { pre => {
let pre: Ppre = pre.into(); let pre: Ppre = pre.into();
let pre: u8 = 1 << (pre.0 - 3); let pre: u8 = 1 << (pre.to_bits() - 3);
let freq = ahb_freq / pre as u32; let freq = ahb_freq / pre as u32;
(freq, freq * 2) (freq, freq * 2)
} }

17
embassy-stm32/src/rcc/h7.rs
View file

@ -601,22 +601,22 @@ pub(crate) unsafe fn init(mut config: Config) {
// Core Prescaler / AHB Prescaler / APB3 Prescaler // Core Prescaler / AHB Prescaler / APB3 Prescaler
RCC.d1cfgr().modify(|w| { RCC.d1cfgr().modify(|w| {
w.set_d1cpre(Hpre(d1cpre_bits)); w.set_d1cpre(Hpre::from_bits(d1cpre_bits));
w.set_d1ppre(Dppre(ppre3_bits)); w.set_d1ppre(Dppre::from_bits(ppre3_bits));
w.set_hpre(hpre_bits) w.set_hpre(hpre_bits)
}); });
// Ensure core prescaler value is valid before future lower // Ensure core prescaler value is valid before future lower
// core voltage // core voltage
while RCC.d1cfgr().read().d1cpre().0 != d1cpre_bits {} while RCC.d1cfgr().read().d1cpre().to_bits() != d1cpre_bits {}
// APB1 / APB2 Prescaler // APB1 / APB2 Prescaler
RCC.d2cfgr().modify(|w| { RCC.d2cfgr().modify(|w| {
w.set_d2ppre1(Dppre(ppre1_bits)); w.set_d2ppre1(Dppre::from_bits(ppre1_bits));
w.set_d2ppre2(Dppre(ppre2_bits)); w.set_d2ppre2(Dppre::from_bits(ppre2_bits));
}); });
// APB4 Prescaler // APB4 Prescaler
RCC.d3cfgr().modify(|w| w.set_d3ppre(Dppre(ppre4_bits))); RCC.d3cfgr().modify(|w| w.set_d3ppre(Dppre::from_bits(ppre4_bits)));
// Peripheral Clock (per_ck) // Peripheral Clock (per_ck)
RCC.d1ccipr().modify(|w| w.set_ckpersel(ckpersel)); RCC.d1ccipr().modify(|w| w.set_ckpersel(ckpersel));
@ -640,7 +640,7 @@ pub(crate) unsafe fn init(mut config: Config) {
_ => Sw::HSI, _ => Sw::HSI,
}; };
RCC.cfgr().modify(|w| w.set_sw(sw)); RCC.cfgr().modify(|w| w.set_sw(sw));
while RCC.cfgr().read().sws() != sw.0 {} while RCC.cfgr().read().sws().to_bits() != sw.to_bits() {}
// IO compensation cell - Requires CSI clock and SYSCFG // IO compensation cell - Requires CSI clock and SYSCFG
assert!(RCC.cr().read().csirdy()); assert!(RCC.cr().read().csirdy());
@ -806,7 +806,8 @@ mod pll {
RCC.pllcfgr().modify(|w| w.set_pllfracen(plln, false)); RCC.pllcfgr().modify(|w| w.set_pllfracen(plln, false));
let vco_ck = ref_x_ck * pll_x_n; let vco_ck = ref_x_ck * pll_x_n;
RCC.plldivr(plln).modify(|w| w.set_divp1(Divp((pll_x_p - 1) as u8))); RCC.plldivr(plln)
.modify(|w| w.set_divp1(Divp::from_bits((pll_x_p - 1) as u8)));
RCC.pllcfgr().modify(|w| w.set_divpen(plln, true)); RCC.pllcfgr().modify(|w| w.set_divpen(plln, true));
// Calulate additional output dividers // Calulate additional output dividers

6
embassy-stm32/src/rcc/l0.rs
View file

@ -293,7 +293,7 @@ pub(crate) unsafe fn init(config: Config) {
AHBPrescaler::NotDivided => sys_clk, AHBPrescaler::NotDivided => sys_clk,
pre => { pre => {
let pre: Hpre = pre.into(); let pre: Hpre = pre.into();
let pre = 1 << (pre.0 as u32 - 7); let pre = 1 << (pre.to_bits() as u32 - 7);
sys_clk / pre sys_clk / pre
} }
}; };
@ -302,7 +302,7 @@ pub(crate) unsafe fn init(config: Config) {
APBPrescaler::NotDivided => (ahb_freq, ahb_freq), APBPrescaler::NotDivided => (ahb_freq, ahb_freq),
pre => { pre => {
let pre: Ppre = pre.into(); let pre: Ppre = pre.into();
let pre: u8 = 1 << (pre.0 - 3); let pre: u8 = 1 << (pre.to_bits() - 3);
let freq = ahb_freq / pre as u32; let freq = ahb_freq / pre as u32;
(freq, freq * 2) (freq, freq * 2)
} }
@ -312,7 +312,7 @@ pub(crate) unsafe fn init(config: Config) {
APBPrescaler::NotDivided => (ahb_freq, ahb_freq), APBPrescaler::NotDivided => (ahb_freq, ahb_freq),
pre => { pre => {
let pre: Ppre = pre.into(); let pre: Ppre = pre.into();
let pre: u8 = 1 << (pre.0 - 3); let pre: u8 = 1 << (pre.to_bits() - 3);
let freq = ahb_freq / pre as u32; let freq = ahb_freq / pre as u32;
(freq, freq * 2) (freq, freq * 2)
} }

6
embassy-stm32/src/rcc/l1.rs
View file

@ -294,7 +294,7 @@ pub(crate) unsafe fn init(config: Config) {
AHBPrescaler::NotDivided => sys_clk, AHBPrescaler::NotDivided => sys_clk,
pre => { pre => {
let pre: Hpre = pre.into(); let pre: Hpre = pre.into();
let pre = 1 << (pre.0 as u32 - 7); let pre = 1 << (pre.to_bits() as u32 - 7);
sys_clk / pre sys_clk / pre
} }
}; };
@ -303,7 +303,7 @@ pub(crate) unsafe fn init(config: Config) {
APBPrescaler::NotDivided => (ahb_freq, ahb_freq), APBPrescaler::NotDivided => (ahb_freq, ahb_freq),
pre => { pre => {
let pre: Ppre = pre.into(); let pre: Ppre = pre.into();
let pre: u8 = 1 << (pre.0 - 3); let pre: u8 = 1 << (pre.to_bits() - 3);
let freq = ahb_freq / pre as u32; let freq = ahb_freq / pre as u32;
(freq, freq * 2) (freq, freq * 2)
} }
@ -313,7 +313,7 @@ pub(crate) unsafe fn init(config: Config) {
APBPrescaler::NotDivided => (ahb_freq, ahb_freq), APBPrescaler::NotDivided => (ahb_freq, ahb_freq),
pre => { pre => {
let pre: Ppre = pre.into(); let pre: Ppre = pre.into();
let pre: u8 = 1 << (pre.0 - 3); let pre: u8 = 1 << (pre.to_bits() - 3);
let freq = ahb_freq / pre as u32; let freq = ahb_freq / pre as u32;
(freq, freq * 2) (freq, freq * 2)
} }

6
embassy-stm32/src/rcc/l4.rs
View file

@ -635,7 +635,7 @@ pub(crate) unsafe fn init(config: Config) {
AHBPrescaler::NotDivided => sys_clk, AHBPrescaler::NotDivided => sys_clk,
pre => { pre => {
let pre: Hpre = pre.into(); let pre: Hpre = pre.into();
let pre = 1 << (pre.0 as u32 - 7); let pre = 1 << (pre.to_bits() as u32 - 7);
sys_clk / pre sys_clk / pre
} }
}; };
@ -644,7 +644,7 @@ pub(crate) unsafe fn init(config: Config) {
APBPrescaler::NotDivided => (ahb_freq, ahb_freq), APBPrescaler::NotDivided => (ahb_freq, ahb_freq),
pre => { pre => {
let pre: Ppre = pre.into(); let pre: Ppre = pre.into();
let pre: u8 = 1 << (pre.0 - 3); let pre: u8 = 1 << (pre.to_bits() - 3);
let freq = ahb_freq / pre as u32; let freq = ahb_freq / pre as u32;
(freq, freq * 2) (freq, freq * 2)
} }
@ -654,7 +654,7 @@ pub(crate) unsafe fn init(config: Config) {
APBPrescaler::NotDivided => (ahb_freq, ahb_freq), APBPrescaler::NotDivided => (ahb_freq, ahb_freq),
pre => { pre => {
let pre: Ppre = pre.into(); let pre: Ppre = pre.into();
let pre: u8 = 1 << (pre.0 - 3); let pre: u8 = 1 << (pre.to_bits() - 3);
let freq = ahb_freq / pre as u32; let freq = ahb_freq / pre as u32;
(freq, freq * 2) (freq, freq * 2)
} }

6
embassy-stm32/src/rcc/l5.rs
View file

@ -461,7 +461,7 @@ pub(crate) unsafe fn init(config: Config) {
AHBPrescaler::NotDivided => sys_clk, AHBPrescaler::NotDivided => sys_clk,
pre => { pre => {
let pre: Hpre = pre.into(); let pre: Hpre = pre.into();
let pre = 1 << (pre.0 as u32 - 7); let pre = 1 << (pre.to_bits() as u32 - 7);
sys_clk / pre sys_clk / pre
} }
}; };
@ -470,7 +470,7 @@ pub(crate) unsafe fn init(config: Config) {
APBPrescaler::NotDivided => (ahb_freq, ahb_freq), APBPrescaler::NotDivided => (ahb_freq, ahb_freq),
pre => { pre => {
let pre: Ppre = pre.into(); let pre: Ppre = pre.into();
let pre: u8 = 1 << (pre.0 - 3); let pre: u8 = 1 << (pre.to_bits() - 3);
let freq = ahb_freq / pre as u32; let freq = ahb_freq / pre as u32;
(freq, freq * 2) (freq, freq * 2)
} }
@ -480,7 +480,7 @@ pub(crate) unsafe fn init(config: Config) {
APBPrescaler::NotDivided => (ahb_freq, ahb_freq), APBPrescaler::NotDivided => (ahb_freq, ahb_freq),
pre => { pre => {
let pre: Ppre = pre.into(); let pre: Ppre = pre.into();
let pre: u8 = 1 << (pre.0 - 3); let pre: u8 = 1 << (pre.to_bits() - 3);
let freq = ahb_freq / pre as u32; let freq = ahb_freq / pre as u32;
(freq, freq * 2) (freq, freq * 2)
} }

2
embassy-stm32/src/rcc/u5.rs
View file

@ -126,7 +126,7 @@ pub enum PllM {
impl Into<Pllm> for PllM { impl Into<Pllm> for PllM {
fn into(self) -> Pllm { fn into(self) -> Pllm {
Pllm(self as u8) Pllm::from_bits(self as u8)
} }
} }

4
embassy-stm32/src/rtc/v2.rs
View file

@ -36,7 +36,7 @@ impl<'d, T: Instance> super::Rtc<'d, T> {
#[cfg(rtc_v2wb)] #[cfg(rtc_v2wb)]
let rtcsel = reg.rtcsel(); let rtcsel = reg.rtcsel();
#[cfg(not(rtc_v2wb))] #[cfg(not(rtc_v2wb))]
let rtcsel = reg.rtcsel().0; let rtcsel = reg.rtcsel().to_bits();
if !reg.rtcen() || rtcsel != clock_config { if !reg.rtcen() || rtcsel != clock_config {
#[cfg(not(any(rtc_v2l0, rtc_v2l1)))] #[cfg(not(any(rtc_v2l0, rtc_v2l1)))]
@ -54,7 +54,7 @@ impl<'d, T: Instance> super::Rtc<'d, T> {
// Select RTC source // Select RTC source
#[cfg(not(rtc_v2wb))] #[cfg(not(rtc_v2wb))]
w.set_rtcsel(Rtcsel(clock_config)); w.set_rtcsel(Rtcsel::from_bits(clock_config));
#[cfg(rtc_v2wb)] #[cfg(rtc_v2wb)]
w.set_rtcsel(clock_config); w.set_rtcsel(clock_config);
w.set_rtcen(true); w.set_rtcen(true);

2
embassy-stm32/src/rtc/v3.rs
View file

@ -26,7 +26,7 @@ impl<'d, T: Instance> super::Rtc<'d, T> {
let config_rtcsel = rtc_config.clock_config as u8; let config_rtcsel = rtc_config.clock_config as u8;
#[cfg(not(any(rcc_wl5, rcc_wle)))] #[cfg(not(any(rcc_wl5, rcc_wle)))]
let config_rtcsel = crate::pac::rcc::vals::Rtcsel(config_rtcsel); let config_rtcsel = crate::pac::rcc::vals::Rtcsel::from_bits(config_rtcsel);
if !reg.rtcen() || reg.rtcsel() != config_rtcsel { if !reg.rtcen() || reg.rtcsel() != config_rtcsel {
crate::pac::RCC.bdcr().modify(|w| w.set_bdrst(true)); crate::pac::RCC.bdcr().modify(|w| w.set_bdrst(true));

4
embassy-stm32/src/spi/mod.rs
View file

@ -650,7 +650,7 @@ fn compute_baud_rate(clocks: Hertz, freq: Hertz) -> Br {
_ => 0b111, _ => 0b111,
}; };
Br(val) Br::from_bits(val)
} }
trait RegsExt { trait RegsExt {
@ -772,7 +772,7 @@ fn set_rxdmaen(regs: Regs, val: bool) {
fn finish_dma(regs: Regs) { fn finish_dma(regs: Regs) {
#[cfg(spi_v2)] #[cfg(spi_v2)]
while regs.sr().read().ftlvl() > 0 {} while regs.sr().read().ftlvl().to_bits() > 0 {}
#[cfg(any(spi_v3, spi_v4, spi_v5))] #[cfg(any(spi_v3, spi_v4, spi_v5))]
while !regs.sr().read().txc() {} while !regs.sr().read().txc() {}

2
embassy-stm32/src/usart/mod.rs
View file

@ -869,7 +869,7 @@ fn configure(r: Regs, config: &Config, pclk_freq: Hertz, kind: Kind, enable_rx:
_ => vals::Ps::EVEN, _ => vals::Ps::EVEN,
}); });
#[cfg(not(usart_v1))] #[cfg(not(usart_v1))]
w.set_over8(vals::Over8(over8 as _)); w.set_over8(vals::Over8::from_bits(over8 as _));
}); });
#[cfg(not(usart_v1))] #[cfg(not(usart_v1))]

56
embassy-stm32/src/usb/usb.rs
View file

@ -97,8 +97,8 @@ impl<T: Instance> interrupt::typelevel::Handler<T::Interrupt> for InterruptHandl
} }
epr.set_dtog_rx(false); epr.set_dtog_rx(false);
epr.set_dtog_tx(false); epr.set_dtog_tx(false);
epr.set_stat_rx(Stat(0)); epr.set_stat_rx(Stat::from_bits(0));
epr.set_stat_tx(Stat(0)); epr.set_stat_tx(Stat::from_bits(0));
epr.set_ctr_rx(!epr.ctr_rx()); epr.set_ctr_rx(!epr.ctr_rx());
epr.set_ctr_tx(!epr.ctr_tx()); epr.set_ctr_tx(!epr.ctr_tx());
regs.epr(index).write_value(epr); regs.epr(index).write_value(epr);
@ -143,8 +143,8 @@ fn invariant(mut r: regs::Epr) -> regs::Epr {
r.set_ctr_tx(true); // don't clear r.set_ctr_tx(true); // don't clear
r.set_dtog_rx(false); // don't toggle r.set_dtog_rx(false); // don't toggle
r.set_dtog_tx(false); // don't toggle r.set_dtog_tx(false); // don't toggle
r.set_stat_rx(Stat(0)); r.set_stat_rx(Stat::from_bits(0));
r.set_stat_tx(Stat(0)); r.set_stat_tx(Stat::from_bits(0));
r r
} }
@ -551,7 +551,7 @@ impl<'d, T: Instance> driver::Bus for Bus<'d, T> {
true => Stat::STALL, true => Stat::STALL,
}; };
let mut w = invariant(r); let mut w = invariant(r);
w.set_stat_tx(Stat(r.stat_tx().0 ^ want_stat.0)); w.set_stat_tx(Stat::from_bits(r.stat_tx().to_bits() ^ want_stat.to_bits()));
reg.write_value(w); reg.write_value(w);
} }
} }
@ -570,7 +570,7 @@ impl<'d, T: Instance> driver::Bus for Bus<'d, T> {
true => Stat::STALL, true => Stat::STALL,
}; };
let mut w = invariant(r); let mut w = invariant(r);
w.set_stat_rx(Stat(r.stat_rx().0 ^ want_stat.0)); w.set_stat_rx(Stat::from_bits(r.stat_rx().to_bits() ^ want_stat.to_bits()));
reg.write_value(w); reg.write_value(w);
} }
} }
@ -606,7 +606,7 @@ impl<'d, T: Instance> driver::Bus for Bus<'d, T> {
break; break;
} }
let mut w = invariant(r); let mut w = invariant(r);
w.set_stat_tx(Stat(r.stat_tx().0 ^ want_stat.0)); w.set_stat_tx(Stat::from_bits(r.stat_tx().to_bits() ^ want_stat.to_bits()));
reg.write_value(w); reg.write_value(w);
} }
EP_IN_WAKERS[ep_addr.index()].wake(); EP_IN_WAKERS[ep_addr.index()].wake();
@ -622,7 +622,7 @@ impl<'d, T: Instance> driver::Bus for Bus<'d, T> {
break; break;
} }
let mut w = invariant(r); let mut w = invariant(r);
w.set_stat_rx(Stat(r.stat_rx().0 ^ want_stat.0)); w.set_stat_rx(Stat::from_bits(r.stat_rx().to_bits() ^ want_stat.to_bits()));
reg.write_value(w); reg.write_value(w);
} }
EP_OUT_WAKERS[ep_addr.index()].wake(); EP_OUT_WAKERS[ep_addr.index()].wake();
@ -763,8 +763,8 @@ impl<'d, T: Instance> driver::EndpointOut for Endpoint<'d, T, Out> {
regs.epr(index).write(|w| { regs.epr(index).write(|w| {
w.set_ep_type(convert_type(self.info.ep_type)); w.set_ep_type(convert_type(self.info.ep_type));
w.set_ea(self.info.addr.index() as _); w.set_ea(self.info.addr.index() as _);
w.set_stat_rx(Stat(Stat::NAK.0 ^ Stat::VALID.0)); w.set_stat_rx(Stat::from_bits(Stat::NAK.to_bits() ^ Stat::VALID.to_bits()));
w.set_stat_tx(Stat(0)); w.set_stat_tx(Stat::from_bits(0));
w.set_ctr_rx(true); // don't clear w.set_ctr_rx(true); // don't clear
w.set_ctr_tx(true); // don't clear w.set_ctr_tx(true); // don't clear
}); });
@ -805,8 +805,8 @@ impl<'d, T: Instance> driver::EndpointIn for Endpoint<'d, T, In> {
regs.epr(index).write(|w| { regs.epr(index).write(|w| {
w.set_ep_type(convert_type(self.info.ep_type)); w.set_ep_type(convert_type(self.info.ep_type));
w.set_ea(self.info.addr.index() as _); w.set_ea(self.info.addr.index() as _);
w.set_stat_tx(Stat(Stat::NAK.0 ^ Stat::VALID.0)); w.set_stat_tx(Stat::from_bits(Stat::NAK.to_bits() ^ Stat::VALID.to_bits()));
w.set_stat_rx(Stat(0)); w.set_stat_rx(Stat::from_bits(0));
w.set_ctr_rx(true); // don't clear w.set_ctr_rx(true); // don't clear
w.set_ctr_tx(true); // don't clear w.set_ctr_tx(true); // don't clear
}); });
@ -869,19 +869,19 @@ impl<'d, T: Instance> driver::ControlPipe for ControlPipe<'d, T> {
let mut stat_tx = 0; let mut stat_tx = 0;
if first { if first {
// change NAK -> VALID // change NAK -> VALID
stat_rx ^= Stat::NAK.0 ^ Stat::VALID.0; stat_rx ^= Stat::NAK.to_bits() ^ Stat::VALID.to_bits();
stat_tx ^= Stat::NAK.0 ^ Stat::STALL.0; stat_tx ^= Stat::NAK.to_bits() ^ Stat::STALL.to_bits();
} }
if last { if last {
// change STALL -> VALID // change STALL -> VALID
stat_tx ^= Stat::STALL.0 ^ Stat::NAK.0; stat_tx ^= Stat::STALL.to_bits() ^ Stat::NAK.to_bits();
} }
// Note: if this is the first AND last transfer, the above effectively // Note: if this is the first AND last transfer, the above effectively
// changes stat_tx like NAK -> NAK, so noop. // changes stat_tx like NAK -> NAK, so noop.
regs.epr(0).write(|w| { regs.epr(0).write(|w| {
w.set_ep_type(EpType::CONTROL); w.set_ep_type(EpType::CONTROL);
w.set_stat_rx(Stat(stat_rx)); w.set_stat_rx(Stat::from_bits(stat_rx));
w.set_stat_tx(Stat(stat_tx)); w.set_stat_tx(Stat::from_bits(stat_tx));
w.set_ctr_rx(true); // don't clear w.set_ctr_rx(true); // don't clear
w.set_ctr_tx(true); // don't clear w.set_ctr_tx(true); // don't clear
}); });
@ -908,11 +908,11 @@ impl<'d, T: Instance> driver::ControlPipe for ControlPipe<'d, T> {
regs.epr(0).write(|w| { regs.epr(0).write(|w| {
w.set_ep_type(EpType::CONTROL); w.set_ep_type(EpType::CONTROL);
w.set_stat_rx(Stat(match last { w.set_stat_rx(Stat::from_bits(match last {
// If last, set STAT_RX=STALL. // If last, set STAT_RX=STALL.
true => Stat::NAK.0 ^ Stat::STALL.0, true => Stat::NAK.to_bits() ^ Stat::STALL.to_bits(),
// Otherwise, set STAT_RX=VALID, to allow the host to send the next packet. // Otherwise, set STAT_RX=VALID, to allow the host to send the next packet.
false => Stat::NAK.0 ^ Stat::VALID.0, false => Stat::NAK.to_bits() ^ Stat::VALID.to_bits(),
})); }));
w.set_ctr_rx(true); // don't clear w.set_ctr_rx(true); // don't clear
w.set_ctr_tx(true); // don't clear w.set_ctr_tx(true); // don't clear
@ -937,17 +937,17 @@ impl<'d, T: Instance> driver::ControlPipe for ControlPipe<'d, T> {
let mut stat_rx = 0; let mut stat_rx = 0;
if first { if first {
// change NAK -> STALL // change NAK -> STALL
stat_rx ^= Stat::NAK.0 ^ Stat::STALL.0; stat_rx ^= Stat::NAK.to_bits() ^ Stat::STALL.to_bits();
} }
if last { if last {
// change STALL -> VALID // change STALL -> VALID
stat_rx ^= Stat::STALL.0 ^ Stat::VALID.0; stat_rx ^= Stat::STALL.to_bits() ^ Stat::VALID.to_bits();
} }
// Note: if this is the first AND last transfer, the above effectively // Note: if this is the first AND last transfer, the above effectively
// does a change of NAK -> VALID. // does a change of NAK -> VALID.
regs.epr(0).write(|w| { regs.epr(0).write(|w| {
w.set_ep_type(EpType::CONTROL); w.set_ep_type(EpType::CONTROL);
w.set_stat_rx(Stat(stat_rx)); w.set_stat_rx(Stat::from_bits(stat_rx));
w.set_ep_kind(last); // set OUT_STATUS if last. w.set_ep_kind(last); // set OUT_STATUS if last.
w.set_ctr_rx(true); // don't clear w.set_ctr_rx(true); // don't clear
w.set_ctr_tx(true); // don't clear w.set_ctr_tx(true); // don't clear
@ -977,7 +977,7 @@ impl<'d, T: Instance> driver::ControlPipe for ControlPipe<'d, T> {
let regs = T::regs(); let regs = T::regs();
regs.epr(0).write(|w| { regs.epr(0).write(|w| {
w.set_ep_type(EpType::CONTROL); w.set_ep_type(EpType::CONTROL);
w.set_stat_tx(Stat(Stat::NAK.0 ^ Stat::VALID.0)); w.set_stat_tx(Stat::from_bits(Stat::NAK.to_bits() ^ Stat::VALID.to_bits()));
w.set_ep_kind(last); // set OUT_STATUS if last. w.set_ep_kind(last); // set OUT_STATUS if last.
w.set_ctr_rx(true); // don't clear w.set_ctr_rx(true); // don't clear
w.set_ctr_tx(true); // don't clear w.set_ctr_tx(true); // don't clear
@ -998,8 +998,8 @@ impl<'d, T: Instance> driver::ControlPipe for ControlPipe<'d, T> {
let epr = regs.epr(0).read(); let epr = regs.epr(0).read();
regs.epr(0).write(|w| { regs.epr(0).write(|w| {
w.set_ep_type(EpType::CONTROL); w.set_ep_type(EpType::CONTROL);
w.set_stat_rx(Stat(epr.stat_rx().0 ^ Stat::STALL.0)); w.set_stat_rx(Stat::from_bits(epr.stat_rx().to_bits() ^ Stat::STALL.to_bits()));
w.set_stat_tx(Stat(epr.stat_tx().0 ^ Stat::VALID.0)); w.set_stat_tx(Stat::from_bits(epr.stat_tx().to_bits() ^ Stat::VALID.to_bits()));
w.set_ctr_rx(true); // don't clear w.set_ctr_rx(true); // don't clear
w.set_ctr_tx(true); // don't clear w.set_ctr_tx(true); // don't clear
}); });
@ -1029,8 +1029,8 @@ impl<'d, T: Instance> driver::ControlPipe for ControlPipe<'d, T> {
let epr = regs.epr(0).read(); let epr = regs.epr(0).read();
regs.epr(0).write(|w| { regs.epr(0).write(|w| {
w.set_ep_type(EpType::CONTROL); w.set_ep_type(EpType::CONTROL);
w.set_stat_rx(Stat(epr.stat_rx().0 ^ Stat::STALL.0)); w.set_stat_rx(Stat::from_bits(epr.stat_rx().to_bits() ^ Stat::STALL.to_bits()));
w.set_stat_tx(Stat(epr.stat_tx().0 ^ Stat::STALL.0)); w.set_stat_tx(Stat::from_bits(epr.stat_tx().to_bits() ^ Stat::STALL.to_bits()));
w.set_ctr_rx(true); // don't clear w.set_ctr_rx(true); // don't clear
w.set_ctr_tx(true); // don't clear w.set_ctr_tx(true); // don't clear
}); });

4
embassy-stm32/src/usb_otg/usb.rs
View file

@ -97,7 +97,7 @@ impl<T: Instance> interrupt::typelevel::Handler<T::Interrupt> for InterruptHandl
vals::Pktstsd::SETUP_DATA_DONE => { vals::Pktstsd::SETUP_DATA_DONE => {
trace!("SETUP_DATA_DONE ep={}", ep_num); trace!("SETUP_DATA_DONE ep={}", ep_num);
} }
x => trace!("unknown PKTSTS: {}", x.0), x => trace!("unknown PKTSTS: {}", x.to_bits()),
} }
} }
@ -920,7 +920,7 @@ impl<'d, T: Instance> embassy_usb_driver::Bus for Bus<'d, T> {
trace!("enumdne"); trace!("enumdne");
let speed = r.dsts().read().enumspd(); let speed = r.dsts().read().enumspd();
trace!(" speed={}", speed.0); trace!(" speed={}", speed.to_bits());
r.gusbcfg().modify(|w| { r.gusbcfg().modify(|w| {
w.set_trdt(calculate_trdt(speed, T::frequency())); w.set_trdt(calculate_trdt(speed, T::frequency()));

2
embassy-stm32/src/wdg/mod.rs
View file

@ -49,7 +49,7 @@ impl<'d, T: Instance> IndependentWatchdog<'d, T> {
let wdg = T::regs(); let wdg = T::regs();
wdg.kr().write(|w| w.set_key(Key::ENABLE)); wdg.kr().write(|w| w.set_key(Key::ENABLE));
wdg.pr().write(|w| w.set_pr(Pr(pr))); wdg.pr().write(|w| w.set_pr(Pr::from_bits(pr)));
wdg.rlr().write(|w| w.set_rl(rl)); wdg.rlr().write(|w| w.set_rl(rl));
trace!( trace!(