SmokeyMcGames/JinxRyu
1
0
Fork 0
forked from Mirror/Ryujinx
Code Pull requests Activity

Perform bounds checking before list indexer to avoid frequent exceptions (#4438)

Browse source 
* Perform bounds checking before list indexer to avoid frequent ArgumentOutOfRangeExceptions

* do a single compare after casting id and .Count to uint
This commit is contained in:
jhorv 2023-02-25 05:26:39 -05:00 committed by GitHub
parent 095ad923ad
commit 58207685c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Ryujinx.Graphics.Vulkan/IdList.cs
View file

@ -79,10 +79,18 @@ namespace Ryujinx.Graphics.Vulkan
id--; id--;
try try
{
if ((uint)id < (uint)_list.Count)
{ {
value = _list[id]; value = _list[id];
return value != null; return value != null;
} }
else
{
value = null;
return false;
}
}
catch (ArgumentOutOfRangeException) catch (ArgumentOutOfRangeException)
{ {
value = null; value = null;