forked from Mirror/Ryujinx
95c06de4c1
* GPU: Remove swizzle undefined matching and rework depth aliasing @gdkchan pointed out that UI textures in TOTK seemed to be setting their texture swizzle incorrectly (texture was RGB but was sampling A, swizzle for A was wrong), so I determined that SwizzleComponentMatches was the problem and set on eliminating it. This PR combines existing work to select the most recently modified texture (now used when selecting which aliased texture to use) with some additional changes to remove the swizzle check and support aliased view creation. The original observation (#1538) was that we wanted to match depth textures for the purposes of aliasing with color textures, but they often had different swizzle from what was sampled (as it's generally the identity swizzle once rendered). At the time, I decided to allow swizzles to match if only the defined components matched, which fixed the issue in all known cases but could easily be broken by a game _expecting_ a given swizzle, such as a 1/0 value on a component. This error case could also occur in textures that don't even depth alias, such as R11G11B10, as the rule was created to generally apply to all cases. The solution is now to fail this exact match test, and allow the search for an R32 texture to create a swizzled view of a D32 texture (and other such cases). This allows the creation of a view that mismatches the requested format, which wasn't present before and was the reason for the swizzle matching approach. The exact match and view creation rules now follow the same rules over what textures to select when there are multiple options (such as a "perfect" match and an "aliased" match at the same time). It now selects the most recently modified texture, which is done with a new sequence number in the GpuContext (because we don't have enough of these). Reportedly fixes UI having weird coloured backgrounds in TOTK. This also fixes an issue in MK8D where returning from a race resulted in the character selection cubemaps being broken. May work around issues introduced by the "short texture cache" PR due to modification ordering, though they won't be truly fixed. Should allow (#4365) to avoid copies in more cases. Need to test that. I tested a bunch of games #1538 originally affected and they seem to be fine. This change affects all games so it would be good to get some wide testing on it. * Address feedback 1, fix an issue * Workaround: Do not allow copies for format alias. These should be removed when D32<->R32 copy dependencies become legal |
||
|---|---|---|
| .. | ||
| ARMeilleure | ||
| Ryujinx | ||
| Ryujinx.Audio | ||
| Ryujinx.Audio.Backends.OpenAL | ||
| Ryujinx.Audio.Backends.SDL2 | ||
| Ryujinx.Audio.Backends.SoundIo | ||
| Ryujinx.Ava | ||
| Ryujinx.Common | ||
| Ryujinx.Cpu | ||
| Ryujinx.Graphics.Device | ||
| Ryujinx.Graphics.GAL | ||
| Ryujinx.Graphics.Gpu | ||
| Ryujinx.Graphics.Host1x | ||
| Ryujinx.Graphics.Nvdec | ||
| Ryujinx.Graphics.Nvdec.FFmpeg | ||
| Ryujinx.Graphics.Nvdec.Vp9 | ||
| Ryujinx.Graphics.OpenGL | ||
| Ryujinx.Graphics.Shader | ||
| Ryujinx.Graphics.Texture | ||
| Ryujinx.Graphics.Vic | ||
| Ryujinx.Graphics.Video | ||
| Ryujinx.Graphics.Vulkan | ||
| Ryujinx.Headless.SDL2 | ||
| Ryujinx.HLE | ||
| Ryujinx.Horizon | ||
| Ryujinx.Horizon.Common | ||
| Ryujinx.Horizon.Generators | ||
| Ryujinx.Horizon.Kernel.Generators | ||
| Ryujinx.Input | ||
| Ryujinx.Input.SDL2 | ||
| Ryujinx.Memory | ||
| Ryujinx.SDL2.Common | ||
| Ryujinx.ShaderTools | ||
| Ryujinx.Tests | ||
| Ryujinx.Tests.Memory | ||
| Ryujinx.Tests.Unicorn | ||
| Ryujinx.Ui.Common | ||
| Ryujinx.Ui.LocaleGenerator | ||
| Spv.Generator | ||