totallyregularhuman/Ryujinx
1
0
Fork 0
forked from Mirror/Ryujinx
Code Pull requests Activity

Make use of Random.Shared (#3852)

Browse source
This commit is contained in:
Berkan Diler 2022-11-16 19:34:18 +01:00 committed by GitHub
parent b96794e72b
commit 11aae9cfbc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Ryujinx.HLE/HOS/Services/Friend/ServiceCreator/IFriendService.cs
View file

@ -266,9 +266,8 @@ namespace Ryujinx.HLE.HOS.Services.Friend.ServiceCreator
// NOTE: Calls nn::friends::detail::service::core::PlayHistoryManager::GetInstance and stores the instance. // NOTE: Calls nn::friends::detail::service::core::PlayHistoryManager::GetInstance and stores the instance.
byte[] randomBytes = new byte[8]; byte[] randomBytes = new byte[8];
Random random = new Random();
random.NextBytes(randomBytes); Random.Shared.NextBytes(randomBytes);
// NOTE: Calls nn::friends::detail::service::core::UuidManager::GetInstance and stores the instance. // NOTE: Calls nn::friends::detail::service::core::UuidManager::GetInstance and stores the instance.
// Then call nn::friends::detail::service::core::AccountStorageManager::GetInstance and store the instance. // Then call nn::friends::detail::service::core::AccountStorageManager::GetInstance and store the instance.

2
Ryujinx.HLE/HOS/Services/Nfc/Nfp/VirtualAmiibo.cs
View file

@ -40,7 +40,7 @@ namespace Ryujinx.HLE.HOS.Services.Nfc.Nfp
{ {
byte[] uuid = new byte[9]; byte[] uuid = new byte[9];
new Random().NextBytes(uuid); Random.Shared.NextBytes(uuid);
uuid[3] = (byte)(0x88 ^ uuid[0] ^ uuid[1] ^ uuid[2]); uuid[3] = (byte)(0x88 ^ uuid[0] ^ uuid[1] ^ uuid[2]);
uuid[8] = (byte)(uuid[3] ^ uuid[4] ^ uuid[5] ^ uuid[6]); uuid[8] = (byte)(uuid[3] ^ uuid[4] ^ uuid[5] ^ uuid[6]);

2
Ryujinx.HLE/HOS/Services/Prepo/IPrepoService.cs
View file

@ -89,7 +89,7 @@ namespace Ryujinx.HLE.HOS.Services.Prepo
{ {
byte[] randomBuffer = new byte[8]; byte[] randomBuffer = new byte[8];
new Random().NextBytes(randomBuffer); Random.Shared.NextBytes(randomBuffer);
_systemSessionId = BitConverter.ToUInt64(randomBuffer, 0); _systemSessionId = BitConverter.ToUInt64(randomBuffer, 0);
} }

4
Ryujinx.HLE/HOS/Services/Ro/IRoInterface.cs
View file

@ -32,8 +32,6 @@ namespace Ryujinx.HLE.HOS.Services.Ro
private KProcess _owner; private KProcess _owner;
private IVirtualMemoryManager _ownerMm; private IVirtualMemoryManager _ownerMm;
private static Random _random = new Random();
public IRoInterface(ServiceCtx context) public IRoInterface(ServiceCtx context)
{ {
_nrrInfos = new List<NrrInfo>(MaxNrr); _nrrInfos = new List<NrrInfo>(MaxNrr);
@ -283,7 +281,7 @@ namespace Ryujinx.HLE.HOS.Services.Ro
{ {
while (true) while (true)
{ {
ulong randomOffset = (ulong)(uint)_random.Next(0, (int)addressSpacePageLimit) << 12; ulong randomOffset = (ulong)(uint)Random.Shared.Next(0, (int)addressSpacePageLimit) << 12;
targetAddress = memMgr.GetAddrSpaceBaseAddr() + randomOffset; targetAddress = memMgr.GetAddrSpaceBaseAddr() + randomOffset;